lightbox overlay not covering entire height in IE

This script is really awesome!

I am not sure if this is a bug or if I am doing something wrong, but when there is little content on a page when a Modal iFrame is called, the opaque overlay isn't stretching all the way to the bottom in IE/win. See screenshot: http://my.mousepath.com/xavierftp/modal-ss-iframe.png (google iFrame is opened after clicking on the google logo) It works fine in Firefox and other browsers. This only happens in IE when & with little content on the page.

Has anybody encountered this, and is there a fix? Thanks!

Posted March 30th, 2007 at 1:07pm by xavier

Thanks. This is definitely a bug. I think I know how to fix it, but I haven't tested this. Around line 77 replace:

getDocumentHeight: function(){
    return document.body.scrollHeight;
},

with

getDocumentHeight: function(){
    return Math.max(document.body.scrollHeight,Control.Modal.getWindowHeight());
},

Again, it's untested (and may not be the solution), but at some point I'll go in and fix this. Would you mind posting your HTML so I can use this exact example?

Posted March 30th, 2007 at 2:11pm by ryan

I think that fixes it, thanks! I'll do some more extensive testing on other platforms too.

Here is the latest HTML: http://my.mousepath.com/xavierftp/call.html (calling: http://my.mousepath.com/xavierftp/zapScript.js)

The inline is writing out a clickable image that will launch the iFrame. I've included prototype 1.5 and Modal in one script which makes it kind of lengthy (~2900 lines). At some point I'll have to figure out what parts of the prototype script I can omit.

Posted March 30th, 2007 at 4:16pm by xavier

Hmmm... Same problem in Firefox. I swapped out the code above and it was a fix, but (in Firefox) the overlay is also short the width of the scrollbar. I plugged same fix you mention above into the getDocumentWidth function and it worked...don't know if it broke anything else, though.

Here's the replacement I used (line 72): getDocumentWidth: function(){ return Math.max(document.body.scrollWidth, Control.Modal.getWindowWidth()); },

Cool, simple and very useful script. Thanks.

Posted March 30th, 2007 at 6:54pm by Cf

A new version is available (1.1.3) that fixes this for the height and width. As far as I can tell it works on every browser I test for.

Posted March 30th, 2007 at 9:54pm by ryan

With version 1.2.7 my overlay does not cover the entire HEIGHT in firefox (when scrollbar appears), works fine in IE7 at last.

i am using:

Control.Modal.load(); Control.Modal.open("", {containerClassName: 'wait', overlayClassName: 'wait'});

and in the css modal_overlay.wait {

  background-image:url(../img/wait.gif);
  background-position:center;
  background-repeat:no-repeat;

} and container reseting to be "empty"

i tried to put the wait in the container but does not work (maybe my fault with a css or something)

What could be wrong?

quoting "Cool, simple and very useful script. Thanks." and lightweight

Posted April 12th, 2007 at 6:58am by Surt

I'm using the script in a lot of situations, and I can't seem to duplicate this. Anyone else run into similar problems?

Posted April 14th, 2007 at 1:54pm by ryan